Bug: go base lineup checking doesn't actually require a valid lineup

[Rab]

We tried to start base, we didn't get enough players, so everyone either left or specced.
The picking time ended, the bot checked lineups and decided they were valid despite no players being in the game, the game started.
Now there's a game in progress, so we can't attempt again, either until the 30 minute timer runs out and the game ends, or until a staffer kills the game.

     BaseBot> Welcome to BASE
     BaseBot> A new game will start when two people message me with !cap. For squad vs world, send ?help
wbm will cap, use !cap wbm to second
         wbm> start it rab
wbm will cap, use !cap wbm to second
wbm is assigned as captain for Freq 0
         Rab> !cap
     BaseBot> Assigning you as cap in 20 seconds, or when someone PMs !cap rab to second your cap.
Rab will cap, use !cap Rab to second
wbm seconds Rab as cap
Rab is assigned as captain for Freq 1
Captains you have 10 minutes to set up your lineup correctly!
A game of BASE is starting! Type ?go base to play. -BaseBot
wbm pick a player!
wbm is in for Freq 0 as a Warbird.
Rab pick a player!
        Poni> hello
         wbm> hello
         Rab> !add poni:8
Poni is in for Freq 1 as a Shark.
     BaseBot> Poni has been added.
wbm pick a player!
Nipple Nibbler is in for Freq 0 as a Terrier.
Rab pick a player!
         Rab> !add mark:8
Markmrw is in for Freq 1 as a Shark.
     BaseBot> Markmrw has been added.
wbm pick a player!
bitsaver is in for Freq 0 as a Spider.
Rab pick a player!
         Rab> !add rab:5
Rab is in for Freq 1 as a Terrier.
     BaseBot> Rab has been added.
     BaseBot> You've been added to the game.
wbm pick a player!
    bitsaver> dont think we have enuf
         wbm> damn
         wbm> need more
Nipple Nibbl> f this
Nipple Nibbl> go back to distension
         wbm> f
The captain of Freq 0, wbm, has left the arena, anyone of Freq 0 can claim cap with !cap
     BaseBot> poni lagged out!
     BaseBot> markmrw lagged out!
     BaseBot> rab lagged out!
[BASEELIM]  Jav elim to 5 starting now. Type ?go elim to play for $ -Robo Ref
Time is up! Checking lineups..
Lineups are ok! Game will start in 30 seconds!
Go go go!!!

[Rab]

Result of Freq 0 vs. Freq 1: 00:00 - 00:00
,---------------------------------+------+------+-----------+------+------+-----+-----------+----.
|                               K |    D |   TK |    Points |   FT |  TeK | RPD |    Rating | LO |
|                          ,------+------+------+-----------+------+------+-----+-----------+----+
| Freq 0                  /     0 |    0 |    0 |         0 |    0 |    0 |   0 |         0 |  0 |
+------------------------'        |      |      |           |      |      |     |           |    |
|  bitsaver                     0 |    0 |    0 |         0 |    0 |    0 |     |         0 |  0 |
|  Nipple Nibbler               0 |    0 |    0 |         0 |    0 |    0 |     |         0 |  0 |
|  wbm                          0 |    0 |    0 |         0 |    0 |    0 |     |         0 |  0 |
+---------------------------------+------+------+-----------+------+------+-----+-----------+----+
|                          ,------+------+------+-----------+------+------+-----+-----------+----+
| Freq 1                  /     0 |    0 |    0 |         0 |    0 |    0 |   0 |         0 |  0 |
+------------------------'        |      |      |           |      |      |     |           |    |
|  Markmrw                      0 |    0 |    0 |         0 |    0 |    0 |     |         0 |  0 |
|  Poni                         0 |    0 |    0 |         0 |    0 |    0 |     |         0 |  0 |
|  Rab                          0 |    0 |    0 |         0 |    0 |    0 |     |         0 |  0 |
`---------------------------------+------+------+-----------+------+------+-----+-----------+----'
A draw?!
Statistics url: http://www.trenchwars.org/base/129477
MVP: !
A new game will start when two people message me with !cap -BaseBot

[qan]

Lineup checks are just if the number of players on a freq is sufficient. In the case of base, the number is currently 1 on each side. Doesn't seem desirable. Should be raised?

It was previously counting players who were added but have specced toward lineup counts, though. Put in a fix for that.

Finally, if we need to verify a base lineup is acceptable, what should the minimum be? For whatever reason it's erred on the side of flexibility for a long time.

[Rab]

We usually dont start the games until we have at least 5v5, then we add people as they come, and it's generally understood that the first game will suck but the next game will be better.

That fix might be sufficient for now. I'm not trying to prevent games from starting if people are present and willing to try and make it work. I just don't want the bot to go through a 30 minute guaranteed 0-0 draw game if nobody's even playing it.