VB 2005 help

[paradise!]

I need help with my VB prog, so basically its a Login App that has a textbox for Username and password, with the labels and w/e. So i already have everything prepared for actual third party input, i have the text in username(username.text) < 5 characters to display too short. I have a bunch of those kinds of things, now i created an Array called MyUserNameArray. I want the application to verify that the username.text is a value within the UserNameArray. And I also have an array for passwords, with Password.Text and w/e.

So it basically looks like this (i know its probably way wrong, try to understand what im doing):

If (Username.Text.Length < 5) Then MessageBox.Show("Username is too short, please try again")
Dim MyUserNameArray() As String
MyUsernameArray = MyUserNameArray("Billy123, winter4, autumn69, spring9669")
//i have no freekin clue what im doing int he above
If Username.Text.Contains(MyUserNameArray()) Then MessageBox.Show("Excellent, Your login was sucessful") Else MessageBox.Show("Your Username is Invalid")

I also tried chaning the 4th line to: If Username.Text(MyUserNameArray)

helppp

[Noah]

Is that all the code you've written? If not then please post everything, I really want to see more of your coding.

[Kolar]

You need to access a single element within the array, loop through it and compare it to the textBox value. Most Array datatypes are zero based also.

[Noah]

But it isn't an array, it's just a string called something that had the word Array in it!

[Zerzera]

Dim MyUserNameArray() As String
MyUsernameArray = MyUserNameArray("Billy123, winter4, autumn69, spring9669")

I am not a VBer, so I don't know the syntax really, but I think it should be more like:

//declare a variable
Dim MyUsernameArray

//asigning an array -filled with Strings- to the variable
MyUsernameArray = Array("Billy123","winter4","autumn69","spring9669" )

[Ewan]

You might be able to get away with
Dim MyUsernameArray("Billy123","winter4","autumn69","s pring9669") As String

I haven't used VB in a long time, but I assume you recall values as an index of the array.

So would MyUsernameArray(1) return Billy123? (Assuming 1 base index, winter4 if it's 0 base)

If so, I guess you need to set up a for loop from 1 to 5 (or 0 to 4)

EDIT: The above bit has been superseded by my next post, but the bit below still is needed:

In pseudocode

j = 0
for i = 1 to 5                                            //This for loop checks the input 
    If Username.Text == MyUsernameArray(i)  //value vs each password in
        j = 1                                               //the array, setting j = 1
    End                                                     // if it matches any.
End

If j = 1                                                    //This if statement checks
    print("Login Successful!")                        //if j = 1, and if it is
Else                                                        //then it will let you log in
    print("I am sorry, your username is not recognised")
End

I don't know enough about VB syntax to be able to translate the for loop or if statement into Visual Basic for you, but hell, this is your work not mine anyway.

[Ewan]

Ok I've had a look, I am pretty sure you have to do the array like this:

Dim MyUsernameArray(1 to 5) As String

MyUsernameArray(1) = "Billy123"
MyUsernameArray(2) = "winter4"

etc
etc

The thing I put in pseudocode in my last post still applies.

[paradise!]

Ok I've had a look, I am pretty sure you have to do the array like this:

Dim MyUsernameArray(1 to 5) As String

MyUsernameArray(1) = "Billy123"
MyUsernameArray(2) = "winter4"

etc
etc

The thing I put in pseudocode in my last post still applies.

nononono, i know there is an easier way than this, there has to be. There is a function that checks if the input was a value within the array(which i defined as string), so why do i need to make it numbers? Idk ive seen it in java.

[paradise!]

I am not a VBer, so I don't know the syntax really, but I think it should be more like:

//declare a variable
Dim MyUsernameArray

//asigning an array -filled with Strings- to the variable
MyUsernameArray = Array("Billy123","winter4","autumn69","spring9669" )

You have to assign a data type (i think) when you declare, i put mine Dim MyUsernameArray As String, i mean you have to say the array is text dontcha? But then again it really shouldnt matter what data type it is, as long as it is an array it can be numbers or text or both, look now im ranting.

You need to access a single element within the array, loop through it and compare it to the textBox value. Most Array datatypes are zero based also.

Nice and vague Kolar.... Thats what im trying to do..

[Nockm]

Code

Dim LoginIndex = Array.IndexOf(MyUsernameArray, Username.Text)

if WordIndex < 0 then
  MessageBox.Show("Bad username")
else
   if Password.Text = MyUsernameArray(WordIndex) then
     MessageBox.Show("Correct username and password")
   else
     MessageBox.Show("Correct username but bad password")

[paradise!]

Code

Dim LoginIndex = Array.IndexOf(MyUsernameArray, Username.Text)

if WordIndex < 0 then
  MessageBox.Show("Bad username")
else
   if Password.Text = MyUsernameArray(WordIndex) then
     MessageBox.Show("Correct username and password")
   else
     MessageBox.Show("Correct username but bad password")

Can you explain the args of IndexOf..I understand getting the index of usernameArray but not username.text

[Ewan]

nononono, i know there is an easier way than this, there has to be. There is a function that checks if the input was a value within the array(which i defined as string), so why do i need to make it numbers? Idk ive seen it in java.

This is setting up the array, not finding the values within.

What you have done, is set an array with 1 long string "Billy123, winter4, autumn69, spring9669"

The way I said there, sets up an array with 5 values, 1 for each of the logins.

The For loop then takes the input, and checks it against each of these logins in turn.

[Nockm]

Can you explain the args of IndexOf..I understand getting the index of usernameArray but not username.text

Arg #1 is the array you are searching within.
Arg #2 is the element you are looking for.

The array you want to search is the list of usernames... and you want to compare it against what the user wrote... i.e. Username.Text.

The result is -1 if the element is not found in the array (if the login is not found in the list of usernames). Otherwise it will return the index where it is first found.

[Zerzera]

Code

Dim LoginIndex = Array.IndexOf(MyUsernameArray, Username.Text)

if WordIndex < 0 then
  MessageBox.Show("Bad username")
else
   if Password.Text = MyUsernameArray(WordIndex) then
     MessageBox.Show("Correct username and password")
   else
     MessageBox.Show("Correct username but bad password")

You compare the password the user has given -using the the nonexisting variable WordIndex- to a value from the username array?

[Nockm]

You compare the password the user has given -using the the nonexisting variable WordIndex- to a value from the username array?

Correction inspired by Zerzera (my hero)

Dim LoginIndex = Array.IndexOf(MyUsernameArray, Username.Text)

if LoginIndex < 0 then
  MessageBox.Show("Bad username")
else
   if Password.Text = MyPasswordArray(LoginIndex) then
     MessageBox.Show("Correct username and password")
   else
     MessageBox.Show("Correct username but bad password")